Repository navigation
Requeue ClusterSummaries waiting on dependsOn instead of waiting for the poll - #2110
Merged
gianlucam76 merged 1 commit intoNov 20, 2026
Merged
Conversation
…the poll A ClusterSummary blocked on a dependsOn prerequisite (deploy), or a prerequisite waiting for its dependents to be removed (delete), only noticed the change at its next 10 second poll, adding up to 10 seconds per dependency level. When a ClusterSummary becomes Provisioned, its dependents (found through the dependency manager, new GetDependents) are requeued: the in-memory cooldown is expired and the retrigger annotation is updated, so no new watch is needed. When a ClusterSummary is removed, the ClusterSummaries of the profiles it depends on are requeued if they are being deleted: their DeletedInstances entry is cleared and the retrigger annotation is updated. Both are done after the status change has been persisted, so the requeued ClusterSummaries do not read stale state from the cache. With --auto-deploy-dependencies=false the dependency manager tracks nothing and dependents fall back to the poll on deploy; the delete side reads dependsOn directly and is not affected. Measured on 6 fake clusters: a dependent finishes 10s after its prerequisite instead of 19-20s; on delete the prerequisite is removed 15s after its dependent instead of 19-21s, and the whole delete takes 30s instead of 55s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A ClusterSummary blocked on a dependsOn prerequisite (deploy), or a prerequisite waiting for its dependents to be removed (delete), only noticed the change at its next 10 second poll, adding up to 10 seconds per dependency level.
When a ClusterSummary becomes Provisioned, its dependents (found through the dependency manager, new GetDependents) are requeued: the in-memory cooldown is expired and the retrigger annotation is updated, so no new watch is needed.
When a ClusterSummary is removed, the ClusterSummaries of the profiles it depends on are requeued if they are being deleted: their DeletedInstances entry is cleared and the retrigger annotation is updated.
Both are done after the status change has been persisted, so the requeued ClusterSummaries do not read stale state from the cache. With --auto-deploy-dependencies=false the dependency manager tracks nothing and dependents fall back to the poll on deploy; the delete side reads dependsOn directly and is not affected.
Measured on 6 fake clusters: a dependent finishes 10s after its prerequisite instead of 19-20s; on delete the prerequisite is removed 15s after its dependent instead of 19-21s, and the whole delete takes 30s instead of 55s.