Repository navigation
fix: empty chartName for Flux-sourced Helm charts breaks drift detection - #2111
Open
gianlucam76 wants to merge 1 commit into
Open
gianlucam76 wants to merge 1 commit into
gianlucam76 wants to merge 1 commit into
Conversation
Member
Author
|
@wahabmk if you have a chance, can you please test this (I already did, but better if you can as well)? You can use thanks |
ChartName is optional when a Helm chart comes from a Flux source, but it was copied as-is into the ResourceSummary where chartName has MinLength=1. With ContinuousWithDriftDetection the ResourceSummary creation failed, and the deploy was retried forever, bumping the Helm release revision each time. Report the last segment of the Flux source path (falling back to the release name) as chart name in the ResourceSummary. The value is informational only: drift is matched to a chart by release name and namespace, and the chart identity used elsewhere is unchanged. Fixes projectsveltos#2109
gianlucam76
force-pushed
the
fix-flux-empty-chartname-2109
branch
from
November 20, 2026 09:25
ae849c2 to
7aa23df
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChartName is optional when a Helm chart comes from a Flux source, but it was copied as-is into the ResourceSummary where chartName has MinLength=1. With ContinuousWithDriftDetection the ResourceSummary creation failed, and the deploy was retried forever, bumping the Helm release revision each time.
Report the last segment of the Flux source path (falling back to the release name) as chart name in the ResourceSummary. The value is informational only: drift is matched to a chart by release name and namespace, and the chart identity used elsewhere is unchanged.
Fixes #2109