Skip to content

fix: empty chartName for Flux-sourced Helm charts breaks drift detection - #2111

Open
gianlucam76 wants to merge 1 commit into
projectsveltos:mainfrom
gianlucam76:fix-flux-empty-chartname-2109
Open

gianlucam76 wants to merge 1 commit into
projectsveltos:mainfrom
gianlucam76:fix-flux-empty-chartname-2109

Conversation

@gianlucam76

Copy link
Copy Markdown
Member

ChartName is optional when a Helm chart comes from a Flux source, but it was copied as-is into the ResourceSummary where chartName has MinLength=1. With ContinuousWithDriftDetection the ResourceSummary creation failed, and the deploy was retried forever, bumping the Helm release revision each time.

Report the last segment of the Flux source path (falling back to the release name) as chart name in the ResourceSummary. The value is informational only: drift is matched to a chart by release name and namespace, and the chart identity used elsewhere is unchanged.

Fixes #2109

@gianlucam76

Copy link
Copy Markdown
Member Author

@wahabmk if you have a chance, can you please test this (I already did, but better if you can as well)?

You can use make create-clusterto create management cluster with this fix and a managed cluster with label env: fv

thanks

ChartName is optional when a Helm chart comes from a Flux source, but it was
copied as-is into the ResourceSummary where chartName has MinLength=1. With
ContinuousWithDriftDetection the ResourceSummary creation failed, and the
deploy was retried forever, bumping the Helm release revision each time.

Report the last segment of the Flux source path (falling back to the release
name) as chart name in the ResourceSummary. The value is informational only:
drift is matched to a chart by release name and namespace, and the chart
identity used elsewhere is unchanged.

Fixes projectsveltos#2109
@gianlucam76
gianlucam76 force-pushed the fix-flux-empty-chartname-2109 branch from ae849c2 to 7aa23df Compare November 20, 2026 09:25

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: empty chartName for Flux-sourced Helm charts breaks drift detection (ResourceSummary validation)

2 participants