Repository navigation
expfmt: use OpenMetrics gauge histogram sample names - #1039
Open
ViktorBystrov72 wants to merge 1 commit into
Open
ViktorBystrov72 wants to merge 1 commit into
ViktorBystrov72 wants to merge 1 commit into
Conversation
ViktorBystrov72
force-pushed
the
fix/openmetrics-gauge-histogram-suffixes
branch
3 times, most recently
from
November 13, 2026 08:39
64eee1c to
447aa99
Compare
Signed-off-by: Виктор Быстров <anatema@bk.ru>
ViktorBystrov72
force-pushed
the
fix/openmetrics-gauge-histogram-suffixes
branch
from
November 14, 2026 05:45
447aa99 to
fdef733
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenMetrics 1.0 gauge histograms are currently encoded with
_sumand_countseries, although their declared type isgaugehistogram. Consumers following the OpenMetrics suffix rules expect_gsumand_gcount.Use those suffixes for gauge histograms and omit
_createdwhenWithCreatedLinesis enabled, since that series belongs to counter histograms. The existing gauge histogram fixture now checks the correct wire names, the byte count, and suppression of an attached creation timestamp. It fails against the parent implementation.Validation:
make test GOOPTS=-racepassed with Go 1.27.3 and golangci-lint 2.14.0, including root tests, lint, license, and module-tidy checks.git diff --checkpassed.@roidelapluie @gotjosh