Repository navigation
security: ci: read the branch name from the environment - #22
Open
Shengcun-Scanner wants to merge 1 commit into
Open
Shengcun-Scanner wants to merge 1 commit into
Shengcun-Scanner wants to merge 1 commit into
Conversation
The maintenance-scope step echoed the head branch straight into its script, so a branch name containing a command substitution ran in the validation job. Read it from env instead. Co-Authored-By: Shengcun <business@rs-systems-web.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The maintenance-scope check echoes the head branch inside its bash script:
The expression is expanded before bash parses the script, so a pull request from
a branch named
runs that command while the job validates the PR. The job runs on
pull_requestwith
permissions: contents: read, so the blast radius is that job's token andwhatever the step itself can reach — worth closing, not a privileged runner.
Fix
The other
github.head_refuses in this file are insideif:expressions and anexisting
env:block, where the value is data — untouched.Verification
yaml.safe_loadstill parses the workflow.