Repository navigation
size-ratchet: exempt generated skill INDEX.md from the raise-line requirement - #1969
Merged
Merged
Conversation
…uirement Lanes never commit INDEX.md and CI regenerates it from reference files that are ratcheted themselves, so every PR adding or growing a reference failed on the derived index. size-ratchet now skips the raise-line check only for the files scripts/skill_index.py generates (.claude/skills/INDEX.md, <skill>/INDEX.md, <skill>/INDEX-scripts.md, exact depth); hand-written INDEX.md files such as docs/INDEX.md still need the marker, as does every other file, and the silent row-deletion check is unchanged. The RATCHET FAIL message now prints the exact size-budget-raise line to paste into changelog.d/<slug>.md. Three self-tests cover generated INDEX.md growth passing and non-generated growth (NOTES.md, docs/INDEX.md) still failing. Tests: 3/3 new size-ratchet self-tests pass; 7 unrelated dcr-gates opt-in cases FAIL in this sandbox (network/git denied), not touched by this change Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014QNFFPWVcPUbeuvwM5fk2Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stops the size ratchet from failing every lane PR on generated
INDEX.mdgrowth.Each skill's
INDEX.mdis generated byscripts/skill_index.pyfrom the skill's reference files, and CI regenerates it (regen-unlanded.sh). Lanes never commit it, per the lane contract. The ratchet still demanded asize-budget-raise:line whenever an INDEX.md grew, so any PR that added or grew a reference failed. #1960 and #1961 failed this way.scripts/ci-gates.sh(cmd_size_ratchet): rows for the filesscripts/skill_index.pygenerates (.claude/skills/INDEX.md,<skill>/INDEX.md,<skill>/INDEX-scripts.md, exact depth) skip the raise-line check. This moves the obligation and does not weaken it: the reference files that drive INDEX.md growth are still ratcheted. Their budget rows may rise freely; the silent row-deletion check still applies, and hand-written files such asdocs/INDEX.mdstill need a raise line.changelog.d/<slug>.md.scripts/test-ci-gates.sh: 3 self-tests. Generated INDEX.md growth with no raise line passes;NOTES.mdanddocs/INDEX.mdgrowth with no raise line still fail.Tests: 3/3 (new size-ratchet self-tests), run on the commit's own tree.
🤖 Generated with Claude Code
https://claude.ai/code/session_014QNFFPWVcPUbeuvwM5fk2Z