Skip to content

Correct the enable_* Default Claim in the Smoke Stub Comment - #3301

Merged
ptr727 merged 3 commits into
developfrom
feature/enable-defaults-wording-3294
Oct 21, 2026
Merged

ptr727 merged 3 commits into
developfrom
feature/enable-defaults-wording-3294

Conversation

@ptr727

@ptr727 ptr727 commented Oct 21, 2026

Copy link
Copy Markdown
Owner

Closes #3294

The smoke stub comment and its copy in docs/reusable-workflows.md said every enable_* input defaults true. enable_release_asset defaults false, so both now say every enable_* input except enable_release_asset defaults true.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 21, 2026 13:41
@ptr727 ptr727 added the comments Permits the comment lines the pull request adds or edits, which the prose gate otherwise refuses label Oct 21, 2026
@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8b2c6683-27ab-41d6-bb6b-f3c821200de1
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Both comments retain an incidental count and exceed the repository’s concise-comment limits.

2 open issues
What changed in this PR

Corrects smoke workflow comments to note that enable_release_asset defaults to false.

Changes:

  • Updated the catalog smoke stub comment.
  • Updated the matching reusable workflow documentation.
  • Comments still require count removal and concise wording.
File Reviewed change
docs/​reusable-workflows.md Corrected the default claim in the documentation comment.
catalog/​snippets/​workflows/​test-pull-request-smoke.yml Corrected the default claim in the smoke stub comment.

Review effort: Lite

Comment thread catalog/snippets/workflows/test-pull-request-smoke.yml Outdated
Comment thread docs/reusable-workflows.md Outdated
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.49%. Comparing base (848d629) to head (b20ef6e).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3301   +/-   ##
========================================
  Coverage    65.49%   65.49%           
========================================
  Files           17       17           
  Lines        10011    10011           
========================================
  Hits          6557     6557           
  Misses        3454     3454           
Flag Coverage Δ
python-3.13 65.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727

ptr727 commented Oct 21, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 521c99b4c24d84db16b4b366f82b17ed321bc04a, the content this pull request carries at that commit against develop, and it recorded 0 findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Changes are limited to accurate documentation; remaining sentence-length findings are minor nits.

2 open issues
2 resolved since last review

Review effort: Lite

Comment thread catalog/snippets/workflows/test-pull-request-smoke.yml Outdated
Comment thread docs/reusable-workflows.md Outdated
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ptr727

ptr727 commented Oct 21, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head b20ef6eada0bfda50f88577210e70d6692ba8cb6, the content this pull request carries at that commit against develop, and it recorded 0 findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The comments accurately reflect the input defaults, with no unresolved issues.

No open issues 🎉

2 resolved since last review

Review effort: Lite

@ptr727
ptr727 merged commit f6b89d7 into develop Oct 21, 2026
14 checks passed
@ptr727
ptr727 deleted the feature/enable-defaults-wording-3294 branch October 21, 2026 16:57
ptr727 added a commit that referenced this pull request Oct 21, 2026
… Fix to Main (#3310)

## Summary

Promotes these pull requests from develop.

- [#3306](#3306): the
write guard reads git config and alias rewrites it previously missed,
each fix adding a denial or failing closed.
- [#3301](#3301): corrects
the smoke stub comment's `enable_*` default claim, since
`enable_release_asset` defaults false.

Closes #3046
Closes #3047
Closes #3055
Closes #3057
Closes #3072
Closes #3078
Closes #3081
Closes #3294

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comments Permits the comment lines the pull request adds or edits, which the prose gate otherwise refuses

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants