Skip to content

Allow re-exporting include directories of dependencies - #377

Open
anirudh12032008 wants to merge 3 commits into
pulp-platform:masterfrom
anirudh12032008:transitive-export-include-dirs
Open

anirudh12032008 wants to merge 3 commits into
pulp-platform:masterfrom
anirudh12032008:transitive-export-include-dirs

Conversation

@anirudh12032008

Copy link
Copy Markdown

Closes #340.

Follows the syntax from the issue:

export_include_dirs:
  - include
  - dep: common_cells
    dir: include
  - dep: reqrsp_interface
  • dep: has to be a direct dependency (E33), and dir: has to match one of that dependency's export_include_dirs exactly (E34). Without dir: all of them are passed on.
  • An optional target: works like it does for normal entries.
  • Packages are resolved leaf first, so re-exports chain through several levels.

Added tests/transitive_export_include_dirs_test.sh, plus docs and a changelog entry.

I made a non-direct dep: an error for now; happy to make it search transitive deps instead if you prefer.

Allow `export_include_dirs` entries of the form `dep: <name>` with an
optional `dir`, which pass the exported include directories of a direct
dependency on to dependent packages. Re-exports chain through packages and
keep the target filters of the original directories (pulp-platform#340).

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Propagate export_include_dirs transitively for public header dependencies

1 participant