Repository navigation
Allow re-exporting include directories of dependencies - #377
Open
anirudh12032008 wants to merge 3 commits into
Open
anirudh12032008 wants to merge 3 commits into
anirudh12032008 wants to merge 3 commits into
Conversation
Allow `export_include_dirs` entries of the form `dep: <name>` with an optional `dir`, which pass the exported include directories of a direct dependency on to dependent packages. Re-exports chain through packages and keep the target filters of the original directories (pulp-platform#340).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #340.
Follows the syntax from the issue:
dep:has to be a direct dependency (E33), anddir:has to match one of that dependency'sexport_include_dirsexactly (E34). Withoutdir:all of them are passed on.target:works like it does for normal entries.Added tests/transitive_export_include_dirs_test.sh, plus docs and a changelog entry.
I made a non-direct
dep:an error for now; happy to make it search transitive deps instead if you prefer.