Repository navigation
Chore/validate purview 2026 10 - #147
Merged
Merged
Conversation
The TelemetryNames class stage combined resolvedNames with CompilationProvider, putting a Compilation into a cached pipeline value. A Compilation is compared by reference and is a new instance on every keystroke, so that stage could never report cached and everything downstream recomputed every time. The referenced assemblies names and this assembly name are now projected into a value-equatable ReferencedTelemetryNamesContext before they reach a cached node, which is the pattern assemblyNameProvider and assemblySettings already use in the same method. Collect now runs for every compilation rather than only when the aggregated class is generated. That is the cost of keeping the Compilation out of cached state, and a net win: the previous shape recomputed that stage and everything below it unconditionally. Flagged by PSGFR33 in Purview.SourceGeneratorFramework 1.2.0. Takes Purview.BuildSdk 1.1.0, Purview.Build 0.7.0, Purview.SourceGeneratorFramework 1.2.0 and Purview.Skills.Testing 1.1.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.