Skip to content

fix(harness): sign-in contract test never reaches a real putio or adb - #867

Merged
altaywtf merged 5 commits into
mainfrom
fix/789-sign-in-harness-isolation
Nov 20, 2026
Merged

altaywtf merged 5 commits into
mainfrom
fix/789-sign-in-harness-isolation

Conversation

@altaywtf

@altaywtf altaywtf commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Change

The sign-in contract test calls only its fake putio and adb, or stops before the script runs. Part of #858.

Windows, TMPDIR=C:/…, stray /usr/bin/putio main this PR
Fakes on PATH dropped (C: splits it) kept (/c/…)
Stray putio called yes no
  • Each case first proves putio, python3 and the SDK root are the fakes.
  • A trap putio stops the run on a missed lookup; self-checks prove both fire.

Validation

  • ./gradlew verifyScripts on macOS
  • Windows (altay-pc): the table above, measured with a planted trap

Unverified: full Windows verify still fails on #749 and #723.

A drive-letter TMPDIR on Windows (C:/...) put a colon into each case's
PATH, so the fake putio and python3 dropped off it and lookups fell
through to /usr/bin and /bin, where a real CLI could answer.

- Map a drive-letter temp dir to its POSIX path.
- Before each case, prove putio, python3 and the SDK root resolve to the
  fakes, or stop the run before the script starts.
- A trap putio and adb after the fakes on PATH stop the run on any call
  that misses them; two self-checks prove the guard and the trap fire.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T14:56:52.444145Z 3ed833a New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

altaywtf and others added 4 commits November 20, 2026 17:51
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@altaywtf
altaywtf merged commit 38a4527 into main Nov 20, 2026
5 checks passed
@altaywtf
altaywtf deleted the fix/789-sign-in-harness-isolation branch November 20, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant