Repository navigation
fix(harness): sign-in contract test never reaches a real putio or adb - #867
Merged
Merged
Conversation
A drive-letter TMPDIR on Windows (C:/...) put a colon into each case's PATH, so the fake putio and python3 dropped off it and lookups fell through to /usr/bin and /bin, where a real CLI could answer. - Map a drive-letter temp dir to its POSIX path. - Before each case, prove putio, python3 and the SDK root resolve to the fakes, or stop the run before the script starts. - A trap putio and adb after the fakes on PATH stop the run on any call that misses them; two self-checks prove the guard and the trap fire. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
1 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
The sign-in contract test calls only its fake
putioandadb, or stops before the script runs. Part of #858.TMPDIR=C:/…, stray/usr/bin/putioPATHC:splits it)/c/…)putiocalledputio,python3and the SDK root are the fakes.putiostops the run on a missed lookup; self-checks prove both fire.Validation
./gradlew verifyScriptson macOSUnverified: full Windows
verifystill fails on #749 and #723.