Repository navigation
fix(playback): restore the previous audio track when a switched HLS rendition fails to load - #871
Merged
Merged
Conversation
…endition fails to load After an audio switch, a separate HLS audio rendition whose playlist or segments failed to load ended playback on the failure screen; recovery only restored audio for decoder and audio renderer errors. Track recovery now remembers failing audio loads (the manifest's audio rendition URIs, or loads of the audio track type) and, within the switch window, treats a load error that matches one as the audio's failure: it restores the previous track with the "Couldn't switch audio track" notice. A failing video request keeps its own failure. Mobile and TV both pass the manifest's audio URIs. The TV player proof lane gains a case that switches to a missing rendition in a local HLS fixture.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
A rendition that failed before the switch made a later video load failure look like the new audio's, reverting the pick and hiding the video error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
TV: a switched-to HLS audio rendition that fails to load restores the previous track with a notice. Fixes #720.
Segments missing (emulator), Mi Box
Validation
./gradlew verifyand both debug assemblesUnverified: a live put.io rendition failing over HTTPS.