Skip to content

fix(playback): restore the previous audio track when a switched HLS rendition fails to load - #871

Merged
altaywtf merged 2 commits into
mainfrom
fix/720-audio-rendition-load-recovery
Nov 20, 2026
Merged

altaywtf merged 2 commits into
mainfrom
fix/720-audio-rendition-load-recovery

Conversation

@altaywtf

@altaywtf altaywtf commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Change

TV: a switched-to HLS audio rendition that fails to load restores the previous track with a notice. Fixes #720.

Switch to Italian (playlist missing) English restored
  • Matches the failing request to the manifest's audio renditions; video request failures stay the video's own.
  • Mobile gets the same recovery.
Segments missing (emulator), Mi Box
Emulator Mi Box (video surface not captured)

Validation

  • ./gradlew verify and both debug assembles
  • TV proof lane case on emulator and Mi Box; fails with the fix disabled

Unverified: a live put.io rendition failing over HTTPS.

…endition fails to load

After an audio switch, a separate HLS audio rendition whose playlist or
segments failed to load ended playback on the failure screen; recovery
only restored audio for decoder and audio renderer errors.

Track recovery now remembers failing audio loads (the manifest's audio
rendition URIs, or loads of the audio track type) and, within the switch
window, treats a load error that matches one as the audio's failure: it
restores the previous track with the "Couldn't switch audio track"
notice. A failing video request keeps its own failure.

Mobile and TV both pass the manifest's audio URIs. The TV player proof
lane gains a case that switches to a missing rendition in a local HLS
fixture.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T14:57:49.294004Z 9bb8786 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@altaywtf altaywtf mentioned this pull request Nov 20, 2026
4 tasks done
A rendition that failed before the switch made a later video load failure
look like the new audio's, reverting the pick and hiding the video error.
@altaywtf
altaywtf merged commit c302c2a into main Nov 20, 2026
5 checks passed
@altaywtf
altaywtf deleted the fix/720-audio-rendition-load-recovery branch November 20, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android TV: restore the previous audio track when a switched HLS rendition fails to load

1 participant