Skip to content

fix(harness): sign-in contract skips the 0600 check where modes don't exist - #874

Open
altaywtf wants to merge 4 commits into
mainfrom
fix/749-token-mode-on-ntfs
Open

altaywtf wants to merge 4 commits into
mainfrom
fix/749-token-mode-on-ntfs

Conversation

@altaywtf

@altaywtf altaywtf commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Change

The sign-in contract test skips its cached-token 0600 check only where the filesystem keeps no POSIX modes. Fixes #749, part of #858.

Host Mode probe (chmod 640) 0600 check
macOS, Linux not run enforced
Git Bash / Cygwin, mode sticks 640 enforced
Git Bash on NTFS 644 skipped, named in the summary

Validation

  • ./gradlew verifyScripts on macOS; a cache written 0644 still fails there
  • Windows (altay-pc): main fails the cached token is not 0600, this branch passes

Unverified: Cygwin with acl mounts, where the probe should keep the check.

… exist

Git Bash on NTFS reports no POSIX modes, so the cached token's 0600
check from #747 could never pass there. On MSYS and Cygwin hosts the
test now probes whether chmod 600 sticks and skips the check only when
it doesn't. macOS and Linux keep the check unconditionally.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T15:05:34.758378Z d76b847 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

altaywtf and others added 3 commits November 20, 2026 18:00
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

harness: sign-in contract approves-code fails on Windows (cached token mode)

1 participant