Repository navigation
Conversation
PYBIND11_OVERLOAD* macros, get_overload, py::arg_t, py::module_::module_def, and py::detail::_ were deprecated without a warning. Also fill in the deprecated features table in the docs. Assisted-by: ClaudeCode:claude-opus-5-5
Collaborator
|
— codex on behalf of Ralf — Two migration rows could use more precise signatures.
Ralf has yet to review these findings. |
Collaborator
Author
|
🤖 AI text below 🤖 Both points are correct. I checked them against the headers and with a compile test. Fixed in 10951d9.
|
henryiii
force-pushed
the
chore/deprecation-warnings
branch
from
November 21, 2026 18:35
10951d9 to
c29791f
Compare
The capsule row now names the PyCapsule_Destructor overload. The get_type_overload row names get_override and the typed pointer it needs, and the warning now names get_override. Assisted-by: ClaudeCode:claude-fable-5-2
henryiii
force-pushed
the
chore/deprecation-warnings
branch
from
November 21, 2026 18:35
c29791f to
34c28dc
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Some items were deprecated in the docs or in comments, but gave no warning. They now give a compiler warning:
PYBIND11_OVERLOAD*macros (deprecated in 2.6). A macro cannot carry[[deprecated]], so each macro calls a deprecated empty function. The warning shows at the user's line, also when pybind11 is included as a system header.get_overload(2.6)py::arg_t(2.0)py::detail::_(2.9.1)py::module_::module_def(3.0)py::modulestays, without a warning.The deprecated features table in
docs/advanced/deprecated.rstnow has a replacement, version, year, and warning type for each item. Items that started to warn in 3.x are kept until at least 4.0. See the 4.0 discussion in #6270.Suggested changelog entry:
PYBIND11_OVERLOAD*,get_overload,py::arg_t,py::module_::module_def, andpy::detail::_, and filled in the table of deprecated features in the docs.📚 Documentation preview 📚: https://pybind11--6275.org.readthedocs.build/