Repository navigation
ci: use target_compile_definitions for smart holder test define - #6289
Merged
Merged
Conversation
CMake 4.5 warns on add_compile_definitions (non-target-directive), which -Werror=dev makes fatal. Assisted-by: ClaudeCode:claude-opus-5-5
Collaborator
Author
|
Fixing bad CMake usage that now warns breaking CI; going to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should never use non-target commands in CMake.
🤖 AI text below 🤖
Description
CMake 4.5.0 gives a
non-target-directivedev warning foradd_compile_definitions. With-Werror=dev, this stops the configure step in thePYBIND11_TEST_SMART_HOLDER=ONjobs (example: #6288).tests/test_with_catch: put the define ontest_with_catchandexternal_modulewithtarget_compile_definitions.tests/test_cmake_build: remove the define. That directory has only custom targets, and the nested builds do not receive it, so it had no effect.Configured locally with CMake 4.5.0 and
-Werror=dev, and rancpptestwith smart holder on.