Repository navigation
tests: avoid MSVC 14.52 unreachable-code warning in test_buffers - #6290
Merged
Merged
Conversation
Assisted-by: ClaudeCode:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
The new
windows-2025-vs2026runner image (20261111) has MSVC 14.52. With/GL, this compiler inlinesBrokenMatrix::throw_runtime_error()and then warns that thereturn py::buffer_info();after it is unreachable (C4702)./WXmakes this an error, and theabi3t from GIL-enabled Python • windows-latestjob fails (seen on #6285).The
def_bufferlambda now has an explicit return type and throws directly, so it has no unreachable code.