Repository navigation
Conversation
Assisted-by: ClaudeCode:claude-fable-5-2
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Closes #1309. Alternative to #6286 that follows the review there: only integer keys are accepted, and other key types still need an explicit
py::cast(key).obj[key]now accepts a C++ integer, for exampled[1],d[-1],d[std::size_t{2}]ando[1][2]. The key is built withpy::int_.The change adds one constrained template overload of
object_api::operator[]. Thehandle,object &&andconst char *overloads are unchanged.booland character types are excluded.d['a']would otherwise become the key 97, whilepy::castgives astr.py::tuple,py::listandpy::sequencedeclare their ownoperator[], which hides the new overload.t[1]on those types still uses thesize_taccessors.Behaviour change:
obj[0]compiled before, because the literal0converted to a nullconst char *and went topy::str(nullptr). It is now the integer key 0.is_std_char_typemoves fromcast.htodetail/common.hso thatpytypes.hcan use it.Suggested changelog entry:
operator[]onpy::object,py::dictand accessors now accepts a C++ integer as the key (for exampled[1]). The literal0is now the integer key 0; before, it was a nullconst char *.