Skip to content

Clean multipatch domain - #185

Merged
yguclu merged 16 commits into
masterfrom
clean-multipatch-domain
Sep 7, 2026
Merged

Clean multipatch domain#185
yguclu merged 16 commits into
masterfrom
clean-multipatch-domain

Conversation

@yguclu

@yguclu yguclu commented Feb 11, 2026

Copy link
Copy Markdown
Member

Require orientation of interfaces (ornt parameter) between patches in a multipatch domain when:

  • Creating an Interface object (in sympde.topology.basic)
  • Creating a Domain object (in sympde.topology.domain) using either join or from_file constructors

Moreover:

  • Make Connectivity.todict() store the orientation in the output dictionary, hence allowing Domain.export() to save that information to file
  • Add consistency checks when creating a MappedDomain object (from sympde.topology.mapping)
  • Clean up module sympde.expr.evaluation and expand its docstrings
  • Clean up unit tests in modules:
    • sympde.expr.tests.test_expr
    • sympde.topology.tests.test_logical_expr
    • sympde.topology.tests.test_topology
  • [CI] Use pytest-xdist to run unit tests in parallel (excluding sympde.topology.tests.test_gallery, because h5py is not thread-safe)
  • Update library version to 0.20.0

@campospinto campospinto left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's a lot of cleaning!

I don't know if the PR should be merged as is, I just left a few comments for now

Comment thread sympde/expr/tests/test_expr.py Outdated
Comment thread sympde/expr/tests/test_expr.py Outdated
Comment thread sympde/expr/tests/test_expr.py
Comment thread sympde/expr/tests/test_expr.py
Comment thread sympde/expr/tests/test_expr.py
Comment thread sympde/expr/evaluation.py
Comment thread sympde/expr/evaluation.py
Comment thread sympde/topology/tests/test_topology.py
Comment thread sympde/topology/basic.py
Comment thread sympde/topology/mapping.py
@yguclu
yguclu marked this pull request as ready for review September 4, 2026 13:54
@campospinto

Copy link
Copy Markdown
Collaborator

These changes are useful and I think can be merged. Thanks!

@campospinto
campospinto self-requested a review September 7, 2026 10:04
Refactor docstrings for clarity and consistency. Update assertions and formatting for better readability.
@yguclu
yguclu merged commit 93a5dc6 into master Sep 7, 2026
11 checks passed
@yguclu
yguclu deleted the clean-multipatch-domain branch September 7, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants