Repository navigation
👷 ci: run every hook under the cooldown - #305
Merged
Merged
Conversation
pre-commit.ci builds hook environments from the newest releases; the scheduled maintenance pull requests build them under the seven-day cutoff, so a young hook or one that rewrites files on a cold build passed its pull request and failed those jobs. The gate now runs the shared cooled-hooks workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pull request could merge green and still break the scheduled maintenance pull requests. pre-commit.ci builds hook environments from the newest releases, while the maintenance jobs build them with packages from the last seven days held back, so a hook bumped to a younger release, or one that rewrites files when built fresh, only fails there. 🧹
The required gate now runs every hook over the whole tree under that cutoff, through the shared
cooled-hooksworkflow added in github-workflows 6.7.0, so the pull request fails instead. Release preparation moves to the same 6.7.0 pin.