Repository navigation
Conversation
Squashed from PR #490 (BM804/fix/magnet-missing-model-errors). Excluded properties are no longer evaluated by __pyaml_repr__, so a getter raising with str(self) cannot re-enter the repr. Error messages in magnet, CFM magnet, serialized magnet and BPM accessors now use self.name. Adds regression tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@TeresiaOlsson there's some issue with new GitHub rules. We cannot merge without bypass |
|
Hmm... There should already be a bypass for everyone in the maintainer group. Can you check the rulesets and see what is needed for it to work? https://github.com/python-accelerator-middle-layer/pyaml/settings/rules |
I think I understand, we can merge but only if we choose to bypass. It's the way we are supposed to do it @TeresiaOlsson ? |
|
It seems like this is the only way to do it with rulesets. But it's ugly. I will check if it's possible to switch back to branch protection rules and there is a setting to say who is allowed to merge to a specific branch. But as I have understood it rulesets are the new way to do it on Github. |
|
ok I'll merge like this for now |
|
@GamelinAl @gubaidulinvadim I have gone back to the branch protection rules and added that only the pyaml-maintainers team should be allowed to push to main and stable. Does it work better now? |
|
No, I don't think it's better. Github still seems to consider it a bypass rule. Then I'm not sure that this is possible to do. |
|
No, I don't think it does. The problem is that I had to add the pyaml-maintainers team as direct members otherwise it wasn't found in the list of options to give permissions to merge. And that now allows all maintainers to merge by bypassing the review... |
|
There seemed to be another setting to control that. Maybe now it works? Github's interface for permissions is really awful... |
on another PR there's no issue anymore |
See #475 and #490
close #475