Repository navigation
FileSet.map_nested and the staged_out_dir extras wrapper - #165
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General-purpose pieces for building modified copies of filesets that contain others, factored out of the deidentification work in fileformats-medimage and fileformats-biosig. Nothing here is specific to deidentification.
Changes
FileSet.nested_filesets(recursive=True)now also finds filesets inside dicts and lists returned by validated properties (previously skipped).recursive=Falsereturns only the direct children.FileSet.map_nested(out_dir, func):func(nested, dest_dir)to write each directly nested fileset in its mirrored position; returningNonecopies it unchanged. All other files are copied, keeping their layout relative to the common parent.copy(). One that's partly inside and partly outside raisesValueError.staged_out_dirwrapper (exported fromfileformats.core) for extras that write to anout_dirargument, used as@extra(wrapper=staged_out_dir):out_dironly once they return, so only complete output appears there.FileExistsErrorbefore moving anything if the output would overwrite existing files.Tests
core/tests/test_map_nested.pycovering:recursive=False;