chore: drop defunct skyrock and withings backends - #1939
Open
aviseth wants to merge 1 commit into
Open
Conversation
Both hardcode OAuth endpoints on hosts that no longer exist, with no setting to point them elsewhere, so neither backend can complete a login: - skyrock: every endpoint is on api.skyrock.com, which no longer resolves. skyrock.com itself is still up; it is the developer API that is gone. - withings: all three OAuth1 endpoints are on developer.health.nokia.com, from the period when Nokia owned Withings. Neither that host nor health.nokia.com resolves. Withings bought itself back in 2018 and moved to account.withings.com on OAuth2, so this is not a URL swap -- the OAuth1 flow this backend implements no longer exists. Issue python-social-auth#1176
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1939 +/- ##
==========================================
+ Coverage 87.92% 87.95% +0.03%
==========================================
Files 347 344 -3
Lines 13581 13544 -37
Branches 668 668
==========================================
- Hits 11941 11913 -28
+ Misses 1396 1387 -9
Partials 244 244
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another batch for #1176, following the same shape as #1923.
Both backends hardcode their OAuth endpoints on hosts that no longer resolve, and neither exposes a setting to point them elsewhere, so neither can complete a login for anyone:
skyrock — every endpoint is on
api.skyrock.com, which has no DNS record.skyrock.comandwww.skyrock.comboth still resolve, so the site is alive and it is specifically the developer API that is gone.withings — all three OAuth1 endpoints are on
developer.health.nokia.com, dating from when Nokia owned Withings. Neither that host norhealth.nokia.comresolves. Withings bought itself back from Nokia in 2018 and now authenticates ataccount.withings.comover OAuth2, so this is not a URL swap: the OAuth1 flowWithingsOAuthimplements is not offered any more. Repointing would mean rewriting it as an OAuth2 backend, which felt like a separate decision for you rather than something to slip into a removal.Removes the two modules and
test_skyrock.py.withingshad no test. Nothing else in the tree referenced either name.I checked the rest of the watchlist the same way and deliberately did not include several that look dead at first glance but are not:
osso— the demo host is dead butOSSO_BASE_URLis a setting, so self-hosted installs still work.monzo,mendeley— their authorization hosts (auth.getmondo.co.uk,api-oauth2.mendeley.com) are dead, but both companies and APIs are alive atapi.monzo.comandapi.mendeley.com. These want fixing, not removing, and I did not want to guess at the replacement endpoints without being able to test a real flow.etsy—api.etsy.comis gone but the backend already usesopenapi.etsy.comfor v3.Happy to open the monzo/mendeley repoint as a separate PR if you would like it, and to keep working through the list in batches this size.
ruff checkandruff format --checkare clean. The suite is 1178 passed / 185 skipped, with 7 failures intest_google.py::GoogleOneTapTestthat are identically present on an unmodifiedmaster.I did not add a
CHANGELOG.mdentry, matching #1923 — there is no unreleased section open at the moment. Say the word and I will add one.