Repository navigation
Bracket IPv6 hosts in the client Host header - #204
Open
abhishekcpp007 wants to merge 1 commit into
Open
abhishekcpp007 wants to merge 1 commit into
abhishekcpp007 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_url_to_hostusesurlsplit().hostname, which strips the brackets, andconnect_websocketthen builds the header asf'{host}:{port}'. Connecting tows://[::1]:8000/sends:RFC 6455 4.1 says the Host field follows RFC 3986, so an IPv6 literal needs brackets:
[::1]:8000.Endpoint.urlin the same file already brackets IPv6 addresses this way.The header now gets brackets when the host contains
:. The bare host still goes toopen_tcp_streamandopen_ssl_over_tcp_stream, and hostnames and IPv4 addresses are unchanged.Added
test_client_ipv6_host_header, which serves on::1withtrio.serve_tcpand checks the raw request. It needs IPv6 loopback, which GitHub runners have.