Repository navigation
feat(TimestampedGeoJson): support marker-only animation without redrawing paths - #2323
Open
senanurcetin wants to merge 3 commits into
Open
senanurcetin wants to merge 3 commits into
senanurcetin wants to merge 3 commits into
Conversation
8 of 23 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #1945.
Add the opt-in
show_path=Falsesetting toTimestampedGeoJsonto animate moving last-point markers without drawing LineString paths in every animation frame. The defaultshow_path=Truepreserves existing behavior.Previously, Leaflet.TimeDimension could recreate polylines at every frame. Without explicit styling, these could appear as unwanted blue lines.
Changes
show_path: bool = True, preserving the existing default.add_last_point=True.Changed files:
folium/plugins/timestamped_geo_json.pytests/plugins/test_timestamped_geo_json.pyVerification reported for the contributor branch
git diff --check: passed locally.show_path=FalseThese are previously reported functional checks, not an independent current-head CI result or an FPS/CPU benchmark. Skipping per-frame polyline construction does not itself establish measured rendering-performance gains.
Scope and limitations
This PR changes only the Folium plugin and its tests. It does not change how source track features are indexed. Browser frame rate, CPU usage and full upstream CI have not been verified in this description.
AI assistance
AI assistance was used for investigation, implementation and regression-test development. Maintainer review remains welcome.