gh-155373: Inline the parsing code of optional groups in Argument Clinic - #155374
Merged
serhiy-storchaka merged 5 commits intoAug 23, 2026
Conversation
…nt Clinic Instead of one PyArg_ParseTuple() call per number of arguments, generate the inlined code of the converters, as for all other parsing methods. Every argument is parsed once. Such functions now use the fastcall convention, except for constructors and other functions which need a tuple.
serhiy-storchaka
requested review from
AA-Turner and
erlend-aasland
as code owners
August 8, 2026 08:20
# Conflicts: # Modules/clinic/_ssl.c.h # Tools/clinic/libclinic/clanguage.py # Tools/clinic/libclinic/parse_args.py
# Conflicts: # Modules/clinic/_cursesmodule.c.h # Modules/clinic/_ssl.c.h
# Conflicts: # Modules/clinic/_cursesmodule.c.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of one
PyArg_ParseTuple()call per number of arguments, generate the inlined code of the converters, as for all other parsing methods. Every argument is parsed once: the groups on the left are parsed if the number of arguments is large enough and shift the following arguments, the required parameters are parsed unconditionally, and the groups on the right depend on the number of arguments.Such functions now use the fastcall convention, except for constructors and other functions which need a tuple. The hand-written
subpadentry inModules/_cursesmodule.c, which reuses the function generated for_curses.window.subwin, is updated accordingly.Errors for a wrong type of an argument are now reported by the converter, as in other functions. Where a group can shift the position of an argument, the message does not contain its number, because it differs between the calls.
Converters whose code cannot be inlined (
str(encoding=...)for example) keep the current code.