gh-155375: -shared-libsan for linux ASAN builds - #155420
Open
lucascolley wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@isuruf gentle bump |
isuruf
reviewed
Aug 24, 2026
lucascolley
marked this pull request as draft
August 29, 2026 13:39
lucascolley
force-pushed
the
shared-libsan
branch
from
August 29, 2026 13:46
7febf22 to
71da576
Compare
lucascolley
commented
Aug 29, 2026
[skip ci] Co-authored-by: Isuru Fernando <isuruf@gmail.com>
lucascolley
force-pushed
the
shared-libsan
branch
from
August 29, 2026 20:59
71da576 to
3dbfe98
Compare
lucascolley
marked this pull request as ready for review
August 29, 2026 21:04
isuruf
reviewed
Aug 29, 2026
Comment on lines
+10
to
+12
| if [[ "$target_platform" == linux-* && "$c_compiler" == "clang" ]]; then | ||
| export LDFLAGS="-shared-libsan $LDFLAGS" | ||
| fi |
Contributor
There was a problem hiding this comment.
You need to do this for tsan too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For scipy/scipy#24066 (comment).
cc @isuruf @picnixz
-shared-libsan? #155375