Repository navigation
Conversation
picnixz
added
needs backport to 3.13
cmaloney
reviewed
Aug 9, 2026
…sIO` only Objects exposing `getbuffer()` without being `io.BytesIO` instances are now read through `readinto()`. The `io` module is imported lazily.
`BytesIOProxy` exposes the `io.BytesIO` interface without being an instance of it, so `hashlib.file_digest` reads it with `readinto()` from its current position.
cmaloney
approved these changes
Oct 25, 2026
cmaloney
left a comment
cmaloney
left a comment
Contributor
There was a problem hiding this comment.
The hashlib change is good to me. The test_hashlib seems to add a lot of complexity for the extra things it's testing which seems out of proportion with the amount of hashlib code changed. If it's covering more I think the refactor is reasonable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hashlib.file_digestdoes not honor current position forio.BytesIOinputs #155419