Skip to content

gh-156060: Do not scan every process four times in remote_debugging.get_child_pids() on macOS #156061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 1 commit into from
Aug 19, 2026
+2 −0
Merged

gh-156060: Do not scan every process four times in remote_debugging.get_child_pids() on macOS #156061

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Modules/_remote_debugging/subprocess.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,7 @@ get_child_pids_platform(pid_t target_pid, int recursive, pid_array_t *result)
PyErr_SetString(PyExc_OSError, "Failed to get process count");
goto done;
}
n_pids /= sizeof(pid_t);

/* Allocate buffer for PIDs (add some slack for new processes) */
int buffer_size = n_pids + 64;
Expand All @@ -322,6 +323,7 @@ get_child_pids_platform(pid_t target_pid, int recursive, pid_array_t *result)
PyErr_SetString(PyExc_OSError, "Failed to list PIDs");
goto done;
}
actual /= sizeof(pid_t);

/* Build pid -> ppid mapping */
ppids = (pid_t *)PyMem_Malloc(actual * sizeof(pid_t));
Expand Down
Loading