Skip to content

gh-130821: Add type info to error message in Modules/_abc.c #156080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JMak-Security wants to merge 7 commits into from
+8 −3
Closed

gh-130821: Add type info to error message in Modules/_abc.c #156080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
32deaa9
gh-130821: Add type info to error message in Modules/_abc.c
JMak-Security Aug 20, 2026
9dc6c5d
gh-130821: Refactor _abc.c error message to use standard %T
JMak-Security Aug 20, 2026
4fc5bba
gh-130821: Fix syntax typo in Modules/_abc.c error message
JMak-Security Aug 20, 2026
6eb78a5
📜🤖 Added by blurb_it.
blurb-it[bot] Aug 20, 2026
9864271
Fix mixed line endings in NEWS entry
JMak-Security Aug 20, 2026
4c086ee
Delete Misc/NEWS.d/next/Core_and_Builtins/2026-08-20-04-04-39.gh-issu…
JMak-Security Aug 20, 2026
190175d
Enhance TypeError message for non-iterable items()
JMak-Security Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-08-20-04-04-39.gh-issue-130821.wwb_7S.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Include the type name in the :exc:`TypeError` raised when ``items()`` returns a non-iterable during abstract method computation in :mod:`abc`. Patch by Jason Mak.
10 changes: 7 additions & 3 deletions Modules/_abc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,10 +383,14 @@ compute_abstract_methods(PyObject *self)
}
assert(PyList_Check(items));
for (Py_ssize_t pos = 0; pos < PyList_GET_SIZE(items); pos++) {
PyObject *it = PySequence_Fast(
PyList_GET_ITEM(items, pos),
"items() returned non-iterable");
PyObject *item_obj = PyList_GET_ITEM(items, pos);
PyObject *it = PySequence_Fast(item_obj, "items() returned non-iterable");
if (!it) {
if (PyErr_ExceptionMatches(PyExc_TypeError)) {
PyErr_Format(PyExc_TypeError,
"items() returned non-iterable (type %T)",
item_obj);
}
goto error;
}
if (PySequence_Fast_GET_SIZE(it) != 2) {
Expand Down
Loading