Add a secret --check-unreachable - #21834
Merged
JukkaL merged 3 commits intoAug 12, 2026
Merged
Conversation
A5rocks
force-pushed
the
babys-first-unreachability-checking
branch
from
August 11, 2026 01:39
7b3e8de to
176415d
Compare
A5rocks
force-pushed
the
babys-first-unreachability-checking
branch
from
August 11, 2026 01:41
176415d to
2bce860
Compare
Collaborator
Author
|
Nevermind, GitHub's stacked PRs is not good enough:
:/ (or maybe I'm missing something. I was following https://docs.github.com/en/pull-requests/how-tos/create-pull-requests/creating-stacked-pull-requests#creating-a-stack-from-the-github-website and made A5rocks#1 but I can't seem to find a "Create stack" option...) |
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
JukkaL
approved these changes
Aug 12, 2026
JukkaL
left a comment
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR! It makes sense to implement this incrementally, and when the feature works well enough, we can make it publicly available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #18707, references #21835.
This is very unbaked, but I figure it's best to get the smallest bit in. I'll see if I can figure out stacked PRs to add extra stuff to this (namely decreasing the number of false errors in unreachable code!), but this is probably super easy to review and a good start!