Skip to content

Make it possible to narrow in --check-unreachable #21868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
A5rocks wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −2
Open

Make it possible to narrow in --check-unreachable #21868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions mypy/checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8200,9 +8200,10 @@ def function_type(self, func: FuncBase) -> FunctionLike:
return typ

def push_type_map(self, type_map: TypeMap, *, from_assignment: bool = True) -> None:
if is_unreachable_map(type_map):
unreachable_map = is_unreachable_map(type_map)
if unreachable_map:
self.binder.unreachable()
else:
if not unreachable_map or self.options.check_unreachable:
for expr, type in type_map.items():
self.binder.put(expr, type, from_assignment=from_assignment)

Expand Down
14 changes: 14 additions & 0 deletions test-data/unit/check-unreachable-code.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1778,3 +1778,17 @@ def f2() -> None:
reveal_type(5) # E: Statement is unreachable \
# N: Revealed type is "Literal[5]?"
"something" # E: Statement is unreachable

[case testUnreachableCodeStillNarrows]
# flags: --check-unreachable --warn-unreachable
import enum

class SomeEnum(enum.Enum):
DEFAULT = 0

def f(x: SomeEnum) -> None:
if x is SomeEnum.DEFAULT:
pass
else:
reveal_type(x) # N: Revealed type is "Never"
[builtins fixtures/tuple.pyi]
Loading