Repository navigation
Fix in-place operator lookup on asymmetric properties - #22275
Closed
guitarmanchan911-byte wants to merge 1 commit into
Closed
guitarmanchan911-byte wants to merge 1 commit into
guitarmanchan911-byte wants to merge 1 commit into
Conversation
Augmented assignment now looks up the in-place operator method on the type returned by the getter rather than the type accepted by the setter. This matters for properties and descriptors whose getter and setter types differ. Fixes python#22273. Assisted-by: Codex:GPT-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22273.
Augmented assignment on a property or descriptor now resolves the
in-place operator method on the getter type, then checks the result
against the setter type. Previously the setter type was used for both,
which caused false positives when it was a union without the in-place
method.
Verification: added a regression test;
mypy/test/testcheck.pypasses(8332 passed, 34 skipped, 7 xfailed).
AI assistance: Codex (GPT-5) was used for investigation and
implementation.