PEP 843: Export Statement for DRY Re-exports - #5078
Conversation
Documentation build overview
25 files changed ·
|
0995a62 to
14dda0d
Compare
|
Please add the new PEP checklist to the top post, and start checking things off: https://github.com/python/peps/blob/main/.github/PULL_REQUEST_TEMPLATE/Add%20a%20new%20PEP.md |
|
It would be better to get a sponsor for your PEP and merge the PR before mentioning your PEP on a public discussion: https://discuss.python.org/t/export-statement-for-dry-re-exports/108444. |
Fair point, I'm definitely looking for a sponsor! |
|
I can't find the comment in the review now, but via email I saw this comment from @ZeroIntensity:
I don't think that's quite right though. Of 842, 843, and 844, I would expect whatever combination gets approved would just be marked
|
|
Yes, Jelle disagreed with me as well. I still think |
|
Yeah, let's be careful about sticking to the boring old processes for stuff like this, better to have a broader discussion elsewhere if we want to change it. PEP 12 says:
(Now I remember I've also suggested Replaced/Superseded-by on a non-final PEP before, so it's good the authors didn't take me up on the idea! 😅) If PEP 842 is withdrawn: a withdrawal notice at the top is useful, and this can include some prose with reasoning and link to 843. |
|
Given the accumulating contention surrounding PEP 842, I would like to confirm my sponsorship of PEP 843. |
|
Please don’t force-push. It will be squashed when merged. |
ZeroIntensity
left a comment
There was a problem hiding this comment.
This generally looks good. Let's try to get this up soon, since some people have been confused about why PEP 844 references a PEP that doesn't seem to exist.
|
Please also fix the merge conflicts. |
Peter Bierma (ZeroIntensity) offered to sponsor PEP 843 and asked to be listed as its CODEOWNERS reviewer, so add both. He also flagged that several section headers had underlines longer than their titles; fix all of those to satisfy strict RST underline-length checking.
ZeroIntensity
left a comment
There was a problem hiding this comment.
LGTM. If you're ready to start the discussion, I can merge this.
|
Sounds great, thanks for speedy review |
|
If any of the other reviewers see something they'd like changed, feel free to send a follow-up. |
Basic requirements (all PEP Types)
pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) andPEPheaderuvx pepotron next(orpipx install pepotronthenpep next)AuthororSponsor, and formally confirmed their approvalAuthor,Status(Draft),TypeandCreatedheaders filled out correctlyPEP-Delegate,Topic,RequiresandReplacesheaders completed if appropriate.github/CODEOWNERSfor the PEPStandards Track requirements
Python-Versionset to valid (pre-beta) future Python version, if relevantDiscussions-ToandPost-History