Repository navigation
[hnswlib] Fix Index.get_items return types - #16578
Merged
Merged
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Index.get_itemsdefaults toreturn_type="numpy", but the first overload gave both parameters a default and matchedreturn_type="list", so a plainindex.get_items(ids)was typed aslist[float]instead of a NumPy array; the list form also returns one list per requested id, not a flat list of floats.This reorders the overloads so the default call returns
NDArray[np.float32], makesreturn_type="list"required in the list overloads (positional or keyword), and types the list result aslist[list[float]].Upstream source (v0.8.0): https://github.com/nmslib/hnswlib/blob/v0.8.0/python_bindings/bindings.cpp#L307-L338 (binding with
return_type = "numpy"default at L937); docs: https://github.com/nmslib/hnswlib/blob/v0.8.0/README.mdAI agent used: Claude Code (claude-opus-5-5).