Skip to content

feat: add docs syncing script, but make it golang - #187

Merged
Davidonium merged 5 commits into
mainfrom
feat/sync-with-docs-golang
Sep 2, 2026
Merged

feat: add docs syncing script, but make it golang#187
Davidonium merged 5 commits into
mainfrom
feat/sync-with-docs-golang

Conversation

@AstraBert

@AstraBert AstraBert commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Does the same as #186, but it's in Go :)

@AstraBert
AstraBert requested a review from a team August 28, 2026 15:38
@Davidonium

Copy link
Copy Markdown
Collaborator

I think the implementation is okay.

One thing I expect is having a couple test cases that test the command e2e. As in, call the command and check that the output matches a golden file.

Something that can be implemented in the future is a different markdown generator that keeps the old one going but for the landing pages it implements the requirements without having to parse the already generated ones.

It'd be copying the implementation from the cobra library and changing it so that it implements the requirements for the landing page.
https://github.com/spf13/cobra/blob/v1.10.2/doc/md_docs.go

@AstraBert

Copy link
Copy Markdown
Contributor Author

@Davidonium done! :)) I agree with the idea of developing a command dedicated to generating md directly in the format the landing_page expects, i can work towards and open a PR in the next few days if that's ok :))

@Davidonium

Copy link
Copy Markdown
Collaborator

Last thing missing is the LANDING_PAGE_PAT secret. I would guess this needs to be created in the qdrant-cloud-bot account and it targets the landing page repository.

We need that before merging.

@AstraBert

Copy link
Copy Markdown
Contributor Author

Yes, the PAT in this case would have to have write access to Pull Requests for the qdrant/landing_page repo.

I don't think i have access to the Qdrant Cloud Bot account, could you help me with that/generate the token directly? Thanks! 🙏

@Davidonium

Copy link
Copy Markdown
Collaborator

Done

@Davidonium
Davidonium merged commit fc9b79d into main Sep 2, 2026
7 checks passed
@Davidonium
Davidonium deleted the feat/sync-with-docs-golang branch September 2, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants