Repository navigation
Sharpen Docs and Tests for get_representative_least_absolute_residue - #538
Merged
Merged
Conversation
Marvin-Beckmann
requested changes
Oct 20, 2026
| } | ||
|
|
||
| /// Checks whether every coefficient is mapped into `(-⌈modulus/2⌉, ⌊modulus/2⌋]` | ||
| /// for an odd and an even modulus, i.e. `modulus/2` is mapped to the positive representative. |
Member
There was a problem hiding this comment.
this comment is not fully clear as modulus/2 might not be an integer to be mapped to any representative
Marvin-Beckmann
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements ensures that the documentation for
get_representative_least_absolute_residuefunctions and provides tests for previously not considered edge-cases.