Repository navigation
hexagon: extend conv2d to conv3d - #12
Closed
Mark Todorovich (marktodorovich) wants to merge 3 commits into
Closed
Mark Todorovich (marktodorovich) wants to merge 3 commits into
Mark Todorovich (marktodorovich) wants to merge 3 commits into
Conversation
- New op HTP_OP_CONV_3D is wired through htp-ops.h, main.c (shares op_conv_2d) and the op remap in htp-kparams.cpp. - conv_3d runs on the existing HMX tiled (implicit GEMM) conv2d path. KD and KH are folded into one virtual kernel row (KD*KH), and output rows are counted as N*OD*OH. - htp_kparams_solve_conv3d checks the conv_3d layout and calls the tiled solver htp_kparams_conv2d_tiled, which takes an is3d flag. - The tiled kernel takes the sizes and strides that differ between conv_2d and conv_3d from a struct htp_conv_geom. Only the input stage unfolds depth. - 256-entry DMA queue can no longer overflow Assisted-by: Claude Code
The KH and OH fastdiv values used to unfold conv_3d kh into (kd, kh) and oh into (od, oh) were built per op on the device, each with a 64-bit divide. Pass them in the kernel params instead; they fit in the space the window variant already reserves, so the struct size does not change. Assisted-by: Claude Code
Mark Todorovich (marktodorovich)
force-pushed
the
mtodorov/hexagon-conv3d
branch
from
November 5, 2026 19:42
ced2926 to
fdad23a
Compare
github-actions
Bot
added
documentation
Mark Todorovich (marktodorovich)
changed the base branch from
mtodorov/hexagon-fix-large-dma-stride
to
master
November 5, 2026 19:43
Mark Todorovich (marktodorovich)
changed the title
Mark Todorovich (marktodorovich)
removed
the
documentation
Mark Todorovich (marktodorovich)
requested a review
from Max Krasnyansky (max-krasnyansky)
November 5, 2026 19:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Generalization of HTP CONV_2D implementation to support CONV_3D
Additional information
Requirements
Max Krasnyansky (@max-krasnyansky)