Repository navigation
Upgrade pinned pandoc 3.12.1 → 3.13 (native, CI, pandoc.wasm) - #1138
Merged
Merged
Conversation
…ti84hkx) Move every copy of the pandoc pin to 3.13: PANDOC_PIN, the three CI workflows' PANDOC_VERSION, dev-setup's PANDOC_HYBRID_MIN_VERSION, the filters README, the vendored.toml pandoc-wasm and default-CSL entries, pampa's oracle ceiling, and the docs' minimum-version sentence (it still said 3.11). pandoc.wasm: upstream renamed the release asset (pandoc-3.12.1.wasm.zip -> pandoc-3.13-wasm.zip, inner folder pandoc-wasm/ -> pandoc-3.13-wasm/). Five places derived the version by stripping a '.wasm.zip' suffix, so resources/pandoc-wasm.json now records 'version' explicitly and every consumer reads it (fetch-pandoc-wasm.mjs, capture_pandoc_recordings, the recording replay check, the vendored.toml version source). New zip and wasm SHA-256s; the two request goldens' hash and job_id follow. Replace the stale 'pinned to match Quarto 1.9' workflow comment (from f61d81f, pin 3.8.3) with what actually governs the pin, and update the bump runbook for the asset-name instability. Pandoc's data/default.csl is byte-identical in 3.13; re-recorded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pandoc 3.13's docx reader takes a table column's alignment from its right-aligned cells, so basic-docx's second colspec is AlignRight (3.12.1: AlignDefault) and the imported qmd's Value column becomes '----:'. No other import fixture changes. The native pandoc-recordings were re-captured too but not committed: every difference was capture noise (machine paths, capture date, random EPUB uuids, temp dir names), none from pandoc, and the existing recordings replay unchanged under 3.13. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades q2's pinned pandoc from 3.12.1 to 3.13 everywhere: native pandoc, CI, and the pandoc.wasm that hub-client uses for "Download as" and document import. Quarto 1's 1.12 prereleases are moving to 3.13 as well (quarto-dev/quarto-cli#15320). Braid: bd-dti84hkx.
Changes
Pins (all moved together;
cargo xtask lintchecks that they agree).PANDOC_PIN,PANDOC_VERSIONintest-suite.yml,ts-test-suite.ymlandq2-preview-spa-e2e.yml, dev-setup'sPANDOC_HYBRID_MIN_VERSION, the filters README, thevendored.tomlentries, and pampa'sPANDOC_ORACLE_MAX_VERSION(cargo xtask pandoc-check: all 4 oracle tests pass on 3.13).pandoc.wasm asset name. Upstream renamed the release asset from
pandoc-3.12.1.wasm.ziptopandoc-3.13-wasm.zip(the folder inside the zip changed too). Five places got the version by stripping a.wasm.zipsuffix.resources/pandoc-wasm.jsonnow has an explicitversionfield, and every consumer reads it:fetch-pandoc-wasm.mjs,capture_pandoc_recordings, the recording replay check, andvendored.toml. New zip and wasm SHA-256s; the two request goldens' hash andjob_idchange to match.Minimum version. The version floor follows the pin's major.minor, so q2 now rejects pandoc < 3.13 with Q-20-2 (as the 3.12 bump did for 3.11). The docs still said "3.11 or newer" and now say 3.13.
Workflow comment. Replaced "pinned to match Quarto 1.9". It dates from the 3.8.3 pin in February and has been wrong since the 3.10 bump. The new comment says what actually governs the pin. The bump runbook (
dev-docs/pandoc-wasm-bump.md) is updated, including a warning that upstream's asset names change.Fixtures. Only the
basic-docximport recording changes: 3.13's docx reader fixes a regression introduced in 3.11 (jgm/pandoc#11969), so a right-aligned table column now imports as right-aligned (| ----: |). The native pandoc-recordings were re-captured too, but that re-capture is not committed: all ~85 changed files were capture noise (machine paths, the capture date, random EPUB uuids, temp-dir names), none caused by pandoc, and the existing recordings replay unchanged under 3.13. Cleaning up that non-determinism and the machine-path leaks is filed as bd-b8jy5t5p.Also checked. Pandoc's
default.cslis byte-identical in 3.13 (re-recorded). The 3.13 switch to YAML 1.2 parsing (yes/noare strings; duplicate keys are errors) doesn't reach our pandoc inputs: metadata goes to pandoc as JSON, and our one defaults file only emitstrue/falseand an integer.User-facing changes (hub-client changelog entry included)
Local verification (macOS, pandoc 3.13)
cargo nextest run --workspace --no-fail-fastwith-D warnings: 19196/19197 pass. The one failure iscapture_classifies_pieces, which is unrelated and also fails on main whenever R and rlang are installed (knitr capture reports every chunk error as rlang_error (knitr wraps errors via rlang::entrace) #1129). CI doesn't install R, so it skips there.cargo xtask verify --skip-rust-tests: all green (lint, clippy, fmt, builds, hubtest:ci,test:wasm473/473 against pandoc.wasm 3.13).🤖 Generated with Claude Code