Repository navigation
Keep logo: false through fillLogoPaths so Typst drops the brand logo - #15353
Open
SAMARTHJAISWAL wants to merge 1 commit into
Open
SAMARTHJAISWAL wants to merge 1 commit into
SAMARTHJAISWAL wants to merge 1 commit into
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15311.
The Typst format passes the document
logothroughfillLogoPaths()beforeresolveLogo().resolveLogo()already treatsfalseas "no logo" (since #13922), butfillLogoPaths()turned every falsy value intoundefinedfirst.resolveLogo()then fell back to the brand'ssmall/medium/largelogo, and thepage.typpartial drew it as the page background on every page.This makes
fillLogoPaths()returnfalseunchanged, as the issue suggests, sologo: falsereachesresolveLogo().fillLogoPaths()is only called from the Typst format, and its return type already allowsfalse.Tested:
tests/docs/smoke-all/brand/logo/typst-logo-false-format.qmd(logo: falseundertypst) andtypst-logo-false-top.qmd(logo: falseat the top level). Both use a brand with asmalllogo and a primary colour, and check that the.typoutput has noset page(backgroundand draws no logo image, while the brand colour is still there. Both fail onmainand pass with this change.tests/docs/smoke-all/brand/logo/pass locally (159 passed).Checklist
I have (if applicable):
AI-assisted PR