Throw an error when mixing BigInt and other types in TypedArray.prototype.set - #1715
Closed
sr5434 wants to merge 1 commit into
Closed
Throw an error when mixing BigInt and other types in TypedArray.prototype.set#1715sr5434 wants to merge 1 commit into
sr5434 wants to merge 1 commit into
Conversation
Contributor
|
Isn't this a duplicate of #1694 ? |
Contributor
Author
|
Sorry, I forgot I put one up for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When mixing BigInt and other types in the set method of a TypedArray, a TypeError should be thrown, but instead, undefined is returned by the latest build. Minimal reproducer:
QuickJS output:
NodeJS output:
I patched this issue and added regression tests.