Fix TypedArray.prototype.at() to handle resized ArrayBuffer correctly - #1718
Open
sr5434 wants to merge 1 commit into
Open
Fix TypedArray.prototype.at() to handle resized ArrayBuffer correctly#1718sr5434 wants to merge 1 commit into
sr5434 wants to merge 1 commit into
Conversation
saghul
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug where, when you expand a resizable array buffer backing a typed array, the at method reads from the newly allocated data rather than returning undefined. Below is a minimal reproducer I made:
I checked past PRs/issues, but all I could find was one about shrinking TypedArrays, while this one is about expanding them. I also added a test based on the minimal reproducer above.