Skip to content

Apply the fourth audit: plain language, repetition and consistency - #275

Merged
mikemaccana merged 4 commits into
mainfrom
claude/wonderful-hawking-5gg014-audit4
Oct 7, 2026
Merged

mikemaccana merged 4 commits into
mainfrom
claude/wonderful-hawking-5gg014-audit4

Conversation

@mikemaccana

Copy link
Copy Markdown
Collaborator

This applies every MUST, SHOULD and NIT from the fourth audit (plain language, non-repetition, and consistency within the text and against the programs and figures). Each chapter group's edits were re-checked by an independent pass against the companion code.

Merge quicknode/solana-program-examples' claude/wonderful-hawking-5gg014-audit4 PR first. These chapters describe its changes. Squash-merge recommended: the branch's commits are work-in-progress snapshots.

Following the program changes

  • Options: writers' accounts are created as needed, and buy_option() checks the terms.
  • Lending: interest rounds up.
  • Managed fund: the Pyth verification check, the deposit valuation rounding up, and the math heading.
  • Perps: PnL, funding and pool shares round against the user.
  • Prop AMM: close_market() is in the prose, the tests, and all six handler-list figures.

Claims narrowed or cut, because the programs don't support them

  • The fundraiser's "any mint works" footnote.
  • The betting market's cancel_event() exit, in the Offchain Truth chapter.
  • The perps exit-rule claim.
  • Prop AMM counterparty choice and size ladders, now credited to real venues.

Other

  • Many plain-language, repetition and glossary fixes.
  • "Fronts the rent" vs "pays the rent" is now right in every figure.
  • A paragraph that Paged.js clipped in the paperback (Tokens) is fixed.

Print

PRINT-SPECIFICATION.md now has:

  • 315 pages digital, 313 paperback interior, 273 Letter;
  • a 0.705in spine and a 15.835 x 9.94in wrap.

The cover art implies a 0.690in spine, so re-export the Figma frame at 313 pages for production.

Checks

  • npm run lint: clean.
  • node scripts/check-figure-geometry.mjs: clean across 115 figures.
  • build-pdf-digital, build-pdf-paperback and the Letter build: all succeed, with no clipped text.

🤖 Generated with Claude Code

https://claude.ai/code/session_01UX53A6YR1Hjr8z6WzJxf2q


Generated by Claude Code

@mikemaccana
mikemaccana merged commit 9357193 into main Oct 7, 2026
1 check passed
@mikemaccana
mikemaccana deleted the claude/wonderful-hawking-5gg014-audit4 branch October 13, 2026 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant