Skip to content

feat(argo-workflows): load post_inspection_runbooks from enroll-server-config configmap - #2610

Merged
cardoe merged 1 commit into
mainfrom
post_inspection_runbooks
Oct 29, 2026
Merged

cardoe merged 1 commit into
mainfrom
post_inspection_runbooks

Conversation

@haseebsyed12

Copy link
Copy Markdown
Contributor

What does this change do?

Upgrade impact

  • This change requires operator action to upgrade. If checked, add the
    upgrade-impact label and a release note: run scriv create from the
    repository root and describe the required action in the generated
    changelog.d/ file. See RELEASING.md.

Operator action means anything a deployment has to do beyond a normal resync:
deploy repo or values changes, new or removed secrets, enabling or disabling a
component, or a manual one-time step.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Python test results

838 tests  +719   838 ✅ +719   11s ⏱️ +5s
  1 suites ±  0     0 💤 ±  0 
  1 files   ±  0     0 ❌ ±  0 

Results for commit 70b9a78. ± Comparison against base commit c603f47.

This pull request removes 119 and adds 838 tests. Note that renamed tests count towards both.
ironic_understack.tests.test_device_type ‑ test_device_type_from_directory
ironic_understack.tests.test_device_type ‑ test_device_type_from_yaml
ironic_understack.tests.test_device_type ‑ test_device_type_minimal_yaml
ironic_understack.tests.test_device_type ‑ test_get_resource_class
ironic_understack.tests.test_inspect_hook_chassis_model ‑ test_preserves_other_custom_traits
ironic_understack.tests.test_inspect_hook_chassis_model ‑ test_replaces_stale_chassis_trait
ironic_understack.tests.test_inspect_hook_node_name_check.TestInspectHookNodeNameCheck ‑ test_empty_system_vendor
ironic_understack.tests.test_inspect_hook_node_name_check.TestInspectHookNodeNameCheck ‑ test_matching_name_passes
ironic_understack.tests.test_inspect_hook_node_name_check.TestInspectHookNodeNameCheck ‑ test_mismatched_name_raises
ironic_understack.tests.test_inspect_hook_node_name_check.TestInspectHookNodeNameCheck ‑ test_missing_manufacturer_raises
…
tests.test_bmc ‑ test_bmc_for_ip_address
tests.test_bmc ‑ test_manager_attributes_path_falls_back_to_idrac9_resource
tests.test_bmc ‑ test_manager_attributes_path_uses_advertised_idrac10_resource
tests.test_bmc_bios ‑ test_update_dell_bios_settings_only_patches_settings_not_already_pending
tests.test_bmc_bios ‑ test_update_dell_bios_settings_skips_patch_when_desired_values_are_pending
tests.test_bmc_chassis_info ‑ test_chassis_info_R7615
tests.test_bmc_credentials ‑ test_set_bmc_password_change
tests.test_bmc_credentials ‑ test_set_bmc_password_failed
tests.test_bmc_credentials ‑ test_set_bmc_password_noop
tests.test_bmc_disk ‑ test_dell_disk_attributes
…

♻️ This comment has been updated with latest results.

@haseebsyed12
haseebsyed12 marked this pull request as ready for review October 29, 2026 13:38
@haseebsyed12
haseebsyed12 requested a review from a team October 29, 2026 13:40
@haseebsyed12
haseebsyed12 force-pushed the post_inspection_runbooks branch from 0a4eaf7 to 10eb9e0 Compare October 29, 2026 13:57

@cardoe cardoe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the docs in the argo-events-workflows page that reference this.

Comment thread python/understack-workflows/README.md Outdated
`post_inspection_runbooks` with the same JSON array. Its site default comes from
the `post_inspection_runbooks` key in the `enroll-server-config` ConfigMap,
falling back to `[]` if the ConfigMap or key is absent. An explicit parameter
overrides the site default; pass `-p post_inspection_runbooks='[]'` to skip it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the docs in the argo-events-workflows page for this.

@haseebsyed12
haseebsyed12 force-pushed the post_inspection_runbooks branch 3 times, most recently from 9ceda69 to b54b9bf Compare October 29, 2026 18:17
@haseebsyed12
haseebsyed12 requested a review from cardoe October 29, 2026 18:18
@haseebsyed12
haseebsyed12 force-pushed the post_inspection_runbooks branch 3 times, most recently from 14513cc to 64f2988 Compare October 29, 2026 18:32
@haseebsyed12
haseebsyed12 force-pushed the post_inspection_runbooks branch from 64f2988 to 70b9a78 Compare October 29, 2026 18:36
@cardoe
cardoe added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit 50715c8 Oct 29, 2026
71 checks passed
@cardoe
cardoe deleted the post_inspection_runbooks branch October 29, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants