Repository navigation
feat(argo-workflows): load post_inspection_runbooks from enroll-server-config configmap - #2610
Merged
Merged
Conversation
Python test results838 tests +719 838 ✅ +719 11s ⏱️ +5s Results for commit 70b9a78. ± Comparison against base commit c603f47. This pull request removes 119 and adds 838 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
haseebsyed12
marked this pull request as ready for review
October 29, 2026 13:38
haseebsyed12
force-pushed
the
post_inspection_runbooks
branch
from
October 29, 2026 13:57
0a4eaf7 to
10eb9e0
Compare
cardoe
requested changes
Oct 29, 2026
cardoe
left a comment
Contributor
There was a problem hiding this comment.
Please update the docs in the argo-events-workflows page that reference this.
| `post_inspection_runbooks` with the same JSON array. Its site default comes from | ||
| the `post_inspection_runbooks` key in the `enroll-server-config` ConfigMap, | ||
| falling back to `[]` if the ConfigMap or key is absent. An explicit parameter | ||
| overrides the site default; pass `-p post_inspection_runbooks='[]'` to skip it. |
Contributor
There was a problem hiding this comment.
Please update the docs in the argo-events-workflows page for this.
haseebsyed12
force-pushed
the
post_inspection_runbooks
branch
3 times, most recently
from
October 29, 2026 18:17
9ceda69 to
b54b9bf
Compare
haseebsyed12
force-pushed
the
post_inspection_runbooks
branch
3 times, most recently
from
October 29, 2026 18:32
14513cc to
64f2988
Compare
…r-config configmap
haseebsyed12
force-pushed
the
post_inspection_runbooks
branch
from
October 29, 2026 18:36
64f2988 to
70b9a78
Compare
cardoe
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change do?
Upgrade impact
upgrade-impactlabel and a release note: runscriv createfrom therepository root and describe the required action in the generated
changelog.d/file. See RELEASING.md.Operator action means anything a deployment has to do beyond a normal resync:
deploy repo or values changes, new or removed secrets, enabling or disabling a
component, or a manual one-time step.