Repository navigation
feat(argo-workflows): label enroll and inspect workflow runs - #2612
Merged
Merged
Conversation
Add workflowMetadata labels to the enroll-server, enroll-netdev, enroll-fw and inspect-server WorkflowTemplates: understack.rackspace.com/workflow-kind: enroll | inspect understack.rackspace.com/device-type: server | netdev | fw Runs become filterable in the Argo UI and with `argo list -l`, and give alerts and `understackctl workflow list` a stable key. Per-target labels (target, submitted-by) are added by understackctl at submission time.
haseebsyed12
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
workflowMetadatalabels to the enroll-server, enroll-netdev, enroll-fw and inspect-server WorkflowTemplates:understack.rackspace.com/workflow-kindenroll,inspectunderstack.rackspace.com/device-typeserver,netdev,fwRuns become filterable in the Argo UI and with
argo list -l, and give alerts andunderstackctl workflow lista stable key. The per-target labels (target,submitted-by) are added by understackctl at submission time rather than here, since the target is only known per submission and has to be sanitized to fit label rules.Companion change in understackctl, which adds
workflow enroll-netdev,enroll-fwandlist: rackerlabs/understackctl#9Notes
--kindand--device-typeinunderstackctl workflow listonly match runs created after this is deployed.argo submit --from wftmpl/....