Skip to content

fix: configuration handling for pci device types - #2615

Open
stevekeay wants to merge 1 commit into
mainfrom
fix-pci-device-capacilities
Open

fix: configuration handling for pci device types#2615
stevekeay wants to merge 1 commit into
mainfrom
fix-pci-device-capacilities

Conversation

@stevekeay

@stevekeay stevekeay commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

@stevekeay stevekeay changed the title Fix configuration handling for pci device types fix: configuration handling for pci device types Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026

Copy link
Copy Markdown

Python test results

63 tests   - 56   63 ✅  - 56   4s ⏱️ -2s
 1 suites ± 0    0 💤 ± 0 
 1 files   ± 0    0 ❌ ± 0 

Results for commit 4a1547a. ± Comparison against base commit c603f47.

This pull request removes 119 and adds 63 tests. Note that renamed tests count towards both. 
ironic_understack.tests.test_device_type ‑ test_device_type_from_directory
ironic_understack.tests.test_device_type ‑ test_device_type_from_yaml
ironic_understack.tests.test_device_type ‑ test_device_type_minimal_yaml
ironic_understack.tests.test_device_type ‑ test_get_resource_class
ironic_understack.tests.test_inspect_hook_chassis_model ‑ test_preserves_other_custom_traits
ironic_understack.tests.test_inspect_hook_chassis_model ‑ test_replaces_stale_chassis_trait
ironic_understack.tests.test_inspect_hook_node_name_check.TestInspectHookNodeNameCheck ‑ test_empty_system_vendor
ironic_understack.tests.test_inspect_hook_node_name_check.TestInspectHookNodeNameCheck ‑ test_matching_name_passes
ironic_understack.tests.test_inspect_hook_node_name_check.TestInspectHookNodeNameCheck ‑ test_mismatched_name_raises
ironic_understack.tests.test_inspect_hook_node_name_check.TestInspectHookNodeNameCheck ‑ test_missing_manufacturer_raises
…

tests.test_argo_client.TestArgoClient ‑ test_generate_workflow_name
tests.test_argo_client.TestArgoClient ‑ test_init_with_ssl_verify
tests.test_argo_client.TestArgoClient ‑ test_init_with_token
tests.test_argo_client.TestArgoClient ‑ test_init_without_token
tests.test_argo_client.TestArgoClient ‑ test_kubernetes_token_property
tests.test_argo_client.TestArgoClient ‑ test_run_playbook_creation_failure
tests.test_argo_client.TestArgoClient ‑ test_run_playbook_success
tests.test_argo_client.TestArgoClient ‑ test_run_playbook_with_empty_extra_vars
tests.test_argo_client.TestArgoClient ‑ test_url_stripping
tests.test_argo_client.TestArgoClient ‑ test_wait_for_completion_api_error
…

@stevekeay
Fix configuration handling for pci device types
c496f5e 
The original attempted to pass a dictionary through the oslo
configuration, but in practice this gets mangled on its journey through
helm -> ironic.conf -> olso so we re-implement as a list of strings.
@stevekeay
stevekeay force-pushed the fix-pci-device-capacilities branch from 4a1547a to c496f5e Compare October 30, 2026 14:09

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@stevekeay