Repository navigation
Conversation
A baremetal port with local_group_information is bonded. Derive its port-channel name from the first local_link_information entry and store it under local_group_information["lag"] in the binding profile, so update_port_postcommit and delete_port_postcommit can read it. The number is stateless: 1000 + port*10 + D, where D is the breakout lane (0 if absent) plus 5 for the second switch of a pair. Only fixed-form leaves are supported: slot must be 1, port 1-308, lane 1-4. update_port_precommit generates the name when none is present and writes it to the active binding inside the port update's transaction; an anchor that cannot be named aborts the update. PortContext only holds a snapshot of the binding, and ML2 drops profile changes made in bind_port, so the write goes through the plugin context. Ports bound before this change have no stored name, so postcommit derives it for them.
Python test results497 tests 497 ✅ 4s ⏱️ Results for commit 7212b51. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A baremetal port with local_group_information is bonded. Derive its
port-channel name from the first local_link_information entry and store
it under local_group_information["lag"] in the binding profile, so
update_port_postcommit and delete_port_postcommit can read it.
The number is stateless: 1000 + port*10 + D, where D is the breakout lane
(0 if absent) plus 5 for the second switch of a pair. Only fixed-form
leaves are supported: slot must be 1, port 1-308, lane 1-4.
update_port_precommit generates the name when none is present and writes
it to the active binding inside the port update's transaction; an anchor
that cannot be named aborts the update. PortContext only holds a snapshot
of the binding, and ML2 drops profile changes made in bind_port, so the
write goes through the plugin context. Ports bound before this change
have no stored name, so postcommit derives it for them.