Repository navigation
CI: three test shards per OS from measured weights; Chrome tests share a browser - #503
Merged
Merged
Conversation
…e one browser per file Hosted test shards had grown to 8-10 minutes against their 10-minute cap (one shard of the dev push for 47339ff was cancelled). The growth predates Mermaid: browser, document and live files added since the 2026-10-04 weights defaulted to weight 1, and several old weights were 3-4x low. Weights now come from the CI logs' per-test durations, the Chrome tests launch one browser per file except the launch, idle and crash tests, and the matrix runs three shards per OS so each lands near five minutes under the unchanged 10-minute cap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Hosted test shards ran 8–10 minutes against their 10-minute cap; PR #502's Ubuntu 2/2 shard was cancelled and so was macOS 2/2 of the
devpush for 47339ff (so thatdevtip has no green run yet).Diagnosis
scripts/test-selection.mjsdated from 2026-10-04. Files added since default to weight 1 even when they take 30–120 s (browserEngineChrome121 s on macOS,inputOwnershipLive46 s,arcadeBackgroundLive52 s,queuePreviewLive33 s…), and several old weights were 3–4× low (startupDiscovery22 → 87,copySelectionLive13 → 51).browserEngineChrometest (17) anddiagramsChrometest (8) launched its own Chromium.Changes
sharedLab(): one browser per file for tests about pages; the launch, idle-shutdown and crash tests keep a fresh browser. Locally both files: 36 s (Mermaid tests skipped) → 22 s (all 23 running).--test-timeout=120000is unchanged and no test is weakened or skipped.docs/development-verification.mdupdated. OnlyVerify (22.x)/Verify (26.x)are required checks, so renaming the shard jobs is safe.Verification
testShardingpasses; build passes; both Chrome files pass locally with a real Chrome and Mermaid 12.2.0. This PR's own CI measures the new shard times.