Skip to content

fix(assistant): restore control affordances and anchored disclosures - #286

Open
chaxus wants to merge 5 commits into
mainfrom
codex/assistant-interface-audit
Open

chaxus wants to merge 5 commits into
mainfrom
codex/assistant-interface-audit

Conversation

@chaxus

@chaxus chaxus commented Oct 18, 2026 •

Copy link
Copy Markdown
Member

Merge Verdict

[APPROVE]

Local implementation and independent review are complete. Preserve individual commits, as requested.

Summary

The AI assistant's header and task suggestions could touch their hover backgrounds, artifact import looked like plain text, and the speech privacy disclosure could sit about 52px above its icon while overlapping the language menu.

Restore token-based text insets and recognizable action surfaces, give structured import visible field labels and borders, retain 44px touch targets, remove the extra popup translation, and coordinate the two speech disclosures through existing public events. Record the findings in the assistant design audit.

Risk Analysis

Risk Level Mitigation
Adjacent assistant controls inherit the shared action styling Low Exercise models, sources, artifacts, workspace navigation and composer behavior in the browser
Speech menu changes affect keyboard focus or touch targets Low Cover Enter, Escape, focus return, popup gap and clicks outside the switch track

Design Decisions

  • Follow ranui's semantic color, spacing, radius and control-size tokens.
  • Keep the application's pinned ranui@0.5.0-alpha.6; the public show/open coordination works without a new component release.
  • Implement general floating dismissal behavior in ran PR #428; application positioning uses the existing component anchor calculation.
  • Preserve account-free frontend behavior and existing model/persistence contracts.

Code Concerns

No unresolved findings. Independent follow-up review approved the coarse-pointer import field correction and the updated sidebar geometry assertions.

Verification

Conclusion basis: Verified

  • Full unit suite: 252 files / 6,799 tests passed.
  • Relevant Playwright suite: 30 tests passed, including 360px/1280px light/dark renders, keyboard and touch checks, sources/artifacts, workspace consistency and composer behavior.
  • pnpm run lint:ts and pnpm run format:check passed, including 1,511 immutable archive checks.
  • New speech interaction unit cases were confirmed failing before the fix and passing afterward.

The complete CI run exposed a dictation recovery assertion that clicked a textarea center covered by the newly anchored disclosure. The follow-up test clicks the visible text inset and verifies that outside dismissal also focuses the field. All five dictation cases passed locally against the PR-pinned dependencies and on the exact deployed Cloudflare preview for commit 0392ed9, using real pointer interactions. All current PR checks passed on commit 0392ed9, including preview, Cloudflare Pages semantics, Docker, lint/type/coverage and deployed-preview smoke.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Deploying document with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0392ed9
Status: ✅  Deploy successful!
Preview URL: https://696a4bf7.document-7hm.pages.dev
Branch Preview URL: https://codex-assistant-interface-au.document-7hm.pages.dev

View logs

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant