chore(proto): pull FlowIntent and the consent document RPC - #1910
chore(proto): pull FlowIntent and the consent document RPC#1910rohanchkrabrty wants to merge 1 commit into
Conversation
Pins PROTON_COMMIT to the proton commit that adds the FlowIntent enum, flow_intent and accepted_document_ids on AuthenticateRequest, and the ListConsentDocuments RPC with its request, response and ConsentDocument messages, then regenerates. Generated code only. Nothing references the new symbols yet; the implementation follows. Part of RFC 0002: https://github.com/raystack/frontier/blob/main/docs/rfcs/0002-explicit-consent-at-signup.md Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VW3nysiE4H83VQk6BroMYc
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Makefile updates ChangesProton version pin
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: 🟡 Moderate · up to This change adds generated consent and authentication API definitions, but the build currently pins them to an unmerged feature-branch revision. Update the pin to the final merged revision before merging to avoid relying on a non-final dependency state. Suggested reviewers: 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report for CI Build 33329454195Coverage remained the same at 49.161%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
2 participants
Summary
PROTON_COMMITto the proton change adding the new auth surface (feat(frontier): add FlowIntent and the consent document RPC proton#502) and regenerates. No frontier logic here — the generated code just has to exist before anything in the stack can reference it.FlowIntentenum (UNSPECIFIED/LOGIN/SIGNUP),flow_intent = 6andaccepted_document_ids = 7onAuthenticateRequest, andListConsentDocumentswith its request, response andConsentDocumentmessages. Part of RFC 0002: Explicit consent at signup.flow_intentis an enum rather than a string because the set is closed, and its zero value gives backward compatibility for free — a client that sends nothing keeps today's create-or-get behaviour.oneofcarryingLoginIntentandSignupIntent(RFC alternative 8), sinceAuthenticateRequest.emailis already a field only some strategies use, checked at runtime. Worth settling now: moving later means deprecating field 6 and carrying both for a window.AuthCallbackgains neither field — both ride on the flow, keyed by thestatethe provider returns.PROTON_COMMITpoints at the proton PR branch head, not amaincommit, and must be re-bumped to the squashed commit once feat(frontier): add FlowIntent and the consent document RPC proton#502 merges.