Repository navigation
test(store): org delete keeps service user rows for the deleter to remove - #1988
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 37 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report for CI Build 38362546678Warning No base build found for commit Coverage: 54.756%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
What changes
TestOrgDeleteCountsLiveServiceUsersOnlywithTestOrgDeleteKeepsServiceUserRows.Why
The old test comes from #1977. It expected a hard org delete to fail with a foreign key error while a live service user existed. Since #1973 an org delete only sets
deleted_at, so that error no longer happens. The test fails onmain(theTestworkflow atcaef5beb).The new test checks what happens now. The org row gets
deleted_at, and the service user row stays untouched. Removing service users first is the job of the deleter, not the database.Tests
go test ./internal/store/postgres/passes.