Skip to content

test(e2e): org delete hides the kyc row #1995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohilsurana merged 1 commit into from
Oct 16, 2026
Merged

test(e2e): org delete hides the kyc row #1995

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
99 changes: 99 additions & 0 deletions test/e2e/regression/api_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import (
"connectrpc.com/connect"

"github.com/raystack/frontier/config"
"github.com/raystack/frontier/pkg/db"
"github.com/raystack/frontier/pkg/logger"
frontierv1beta1 "github.com/raystack/frontier/proto/v1beta1"
"github.com/raystack/frontier/proto/v1beta1/frontierv1beta1connect"
Expand Down Expand Up @@ -71,6 +72,7 @@ type APIRegressionTestSuite struct {
orgViewerRole string
orgOwnerRole string
groupMemberRole string
dbc *db.Client
}

func (s *APIRegressionTestSuite) SetupSuite() {
Expand Down Expand Up @@ -104,6 +106,9 @@ func (s *APIRegressionTestSuite) SetupSuite() {
s.testBench, err = testbench.Init(appConfig)
s.Require().NoError(err)

s.dbc, err = db.New(appConfig.DB)
s.Require().NoError(err)

ctx := context.Background()

// Seed the custom "compute" permissions and roles the tests below rely on,
Expand Down Expand Up @@ -154,6 +159,7 @@ func (s *APIRegressionTestSuite) SetupSuite() {
}

func (s *APIRegressionTestSuite) TearDownSuite() {
s.Require().NoError(s.dbc.Close())
err := s.testBench.Close()
s.Require().NoError(err)
}
Expand Down Expand Up @@ -3584,6 +3590,99 @@ func (s *APIRegressionTestSuite) TestOrganizationDeleteHidesTheOrgAndRemovesWhat
})
}

func (s *APIRegressionTestSuite) TestOrganizationDeleteHidesItsKyc() {
ctxOrgAdminAuth := testbench.ContextWithAuth(context.Background(), s.adminCookie)

createOrgResp, err := s.testBench.Client.CreateOrganization(ctxOrgAdminAuth, connect.NewRequest(&frontierv1beta1.CreateOrganizationRequest{
Body: &frontierv1beta1.OrganizationRequestBody{
Title: "org kyc soft delete",
Name: "org-kyc-soft-delete",
},
}))
s.Require().NoError(err)
orgID := createOrgResp.Msg.GetOrganization().GetId()

kycLink := "https://kyc.example/org-kyc-soft-delete"
_, err = s.testBench.AdminClient.SetOrganizationKyc(ctxOrgAdminAuth, connect.NewRequest(&frontierv1beta1.SetOrganizationKycRequest{
OrgId: orgID,
Status: true,
Link: kycLink,
}))
s.Require().NoError(err)

getBeforeDeleteResp, err := s.testBench.Client.GetOrganizationKyc(ctxOrgAdminAuth, connect.NewRequest(&frontierv1beta1.GetOrganizationKycRequest{OrgId: orgID}))
s.Require().NoError(err)
s.Require().True(getBeforeDeleteResp.Msg.GetOrganizationKyc().GetStatus())
s.Require().Equal(kycLink, getBeforeDeleteResp.Msg.GetOrganizationKyc().GetLink())

listBeforeDeleteResp, err := s.testBench.AdminClient.ListOrganizationsKyc(ctxOrgAdminAuth, connect.NewRequest(&frontierv1beta1.ListOrganizationsKycRequest{}))
s.Require().NoError(err)
listedBeforeDelete := false
for _, orgKyc := range listBeforeDeleteResp.Msg.GetOrganizationsKyc() {
if orgKyc.GetOrgId() == orgID {
listedBeforeDelete = true
s.Require().True(orgKyc.GetStatus())
}
}
s.Require().True(listedBeforeDelete)

_, err = s.testBench.Client.DeleteOrganization(ctxOrgAdminAuth, connect.NewRequest(&frontierv1beta1.DeleteOrganizationRequest{Id: orgID}))
s.Require().NoError(err)

s.Run("the deleted org is absent from the kyc list", func() {
Comment thread
rohilsurana marked this conversation as resolved.
listResp, err := s.testBench.AdminClient.ListOrganizationsKyc(ctxOrgAdminAuth, connect.NewRequest(&frontierv1beta1.ListOrganizationsKycRequest{}))
s.Require().NoError(err)
for _, orgKyc := range listResp.Msg.GetOrganizationsKyc() {
s.Assert().NotEqual(orgID, orgKyc.GetOrgId())
}
})

s.Run("the kyc of the deleted org is no longer readable", func() {
getResp, err := s.testBench.Client.GetOrganizationKyc(ctxOrgAdminAuth, connect.NewRequest(&frontierv1beta1.GetOrganizationKycRequest{OrgId: orgID}))
if err != nil {
s.Assert().Contains([]connect.Code{connect.CodeNotFound, connect.CodePermissionDenied}, connect.CodeOf(err))
return
}
s.Assert().False(getResp.Msg.GetOrganizationKyc().GetStatus())
s.Assert().Empty(getResp.Msg.GetOrganizationKyc().GetLink())
})

s.Run("the kyc row stays in the database marked deleted", func() {
var liveRows, deletedRows int
s.Require().NoError(s.dbc.GetContext(context.Background(), &liveRows,
"SELECT count(*) FROM organizations_kyc WHERE org_id = $1 AND deleted_at IS NULL", orgID))
s.Require().NoError(s.dbc.GetContext(context.Background(), &deletedRows,
"SELECT count(*) FROM organizations_kyc WHERE org_id = $1 AND deleted_at IS NOT NULL", orgID))
s.Assert().Equal(0, liveRows)
s.Assert().Equal(1, deletedRows)
})

s.Run("kyc cannot be set on the deleted org", func() {
_, err := s.testBench.AdminClient.SetOrganizationKyc(ctxOrgAdminAuth, connect.NewRequest(&frontierv1beta1.SetOrganizationKycRequest{
OrgId: orgID,
Status: false,
}))
s.Require().Error(err)
s.Assert().Equal(connect.CodeInvalidArgument, connect.CodeOf(err))
})

s.Run("a new org with the same name starts without kyc", func() {
recreateResp, err := s.testBench.Client.CreateOrganization(ctxOrgAdminAuth, connect.NewRequest(&frontierv1beta1.CreateOrganizationRequest{
Body: &frontierv1beta1.OrganizationRequestBody{
Title: "org kyc soft delete again",
Name: "org-kyc-soft-delete",
},
}))
s.Require().NoError(err)
getResp, err := s.testBench.Client.GetOrganizationKyc(ctxOrgAdminAuth, connect.NewRequest(&frontierv1beta1.GetOrganizationKycRequest{
OrgId: recreateResp.Msg.GetOrganization().GetId(),
}))
s.Require().NoError(err)
s.Assert().False(getResp.Msg.GetOrganizationKyc().GetStatus())
s.Assert().Empty(getResp.Msg.GetOrganizationKyc().GetLink())
})
}

func (s *APIRegressionTestSuite) TestOrganizationDeleteAlsoDeletesDisabledProjectsAndGroups() {
ctxOrgAdminAuth := testbench.ContextWithAuth(context.Background(), s.adminCookie)

Expand Down
Loading