Repository navigation
Conversation
ProjectResourceBlockers and OrganizationResourceBlockers return one RESOURCES_EXIST blocker per namespace, with the number of live resources that the app.deletion rules say block the delete. The org check judges the resources of its projects by the organization rules. Nothing calls them yet.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4 tasks done
Coverage Report for CI Build 39113827779Coverage increased (+0.06%) to 55.334%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
ProjectResourceBlockersandOrganizationResourceBlockersto the cascade deleter. Each returns oneRESOURCES_EXISTblocker per namespace, withCountset to the number of live resources that theapp.deletionrules say block the delete. Both return nothing while the block is disabled. Nothing calls them yet. Stacked on #2004.Changes
core/deleter/deleter.go:BlockerResourcesExist,SubjectResourceNamespaceandBlocker.Count. A resource blocker has no message; a client builds the text from the namespace inSubjectand fromCount.core/deleter/resource_blockers.go:projectrules.organizationrules to all of them.allow, or its rule isblock_unless_deletableand its metadata has the boolean"deletable": true. A namespace or delete with no rule blocks.A project with two
compute/machineresources (project: block) and onecompute/orderresource without"deletable": true(project: block_unless_deletable) gets:Test Plan
core/deleter/service_test.goTestProjectResourceBlockers: nothing is read while disabled; counts per namespace, where only the booleandeletable: truecounts and a namespace or delete with no rule blocks; nothing blocks; a list error.TestOrganizationResourceBlockers: nothing is read while disabled; the organization's own and its projects' resources are judged by the organization rules, with counts added across projects; list errors for the organization's resources, its projects, and a project's resources.go test ./core/deleter/...passes.golangci-lint run ./...reports no issues.